From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm_vblank: use dyndbg's static-key to avoid flag-check Date: Sat, 14 Mar 2026 07:00:31 +1000 Message-ID: In-Reply-To: <20260313132103.2529746-66-jim.cromie@gmail.com> References: <20260313132103.2529746-1-jim.cromie@gmail.com> <20260313132103.2529746-66-jim.cromie@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Moves `ktime_to_timespec64()` into `drm_dbg_vbl()` arguments using comma ex= pressions. **The commit message itself flags the problem:** "TBD: if CONFIG= _DRM_USE_DYNAMIC_DEBUG=3DN, this does the ktime conversions unconditionally= ." This is a **regression for non-dyndbg configs** =E2=80=94 it removes the= guard that previously avoided unnecessary ktime conversions. The comma-exp= ression style is also unusual for kernel code. This patch should be deferre= d until `DRM_USE_DYNAMIC_DEBUG=3Dy` is the default. --- Generated by Claude Code Patch Reviewer