From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: analogix_dp: Move the color format check
 to .atomic_check() for Rockchip platforms
Date: Wed, 11 Feb 2026 16:37:17 +1000
Message-ID: <review-patch7-20260210071225.2566099-8-damon.ding@rock-chips.com>
In-Reply-To: <20260210071225.2566099-8-damon.ding@rock-chips.com>
References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210071225.2566099-8-damon.ding@rock-chips.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Mailer: Claude Code Patch Reviewer

Patch Review

**Summary:** Moves YUV-to-RGB color format fixup from get_modes callback to atomic_check.

**Code being moved:**
```c
+static int analogix_dp_bridge_atomic_check(struct drm_bridge *bridge,
+					   struct drm_bridge_state *bridge_state,
+					   struct drm_crtc_state *crtc_state,
+					   struct drm_connector_state *conn_state)
+{
+	struct analogix_dp_device *dp = to_dp(bridge);
+	struct drm_display_info *di = &conn_state->connector->display_info;
+	u32 mask = DRM_COLOR_FORMAT_YCBCR444 | DRM_COLOR_FORMAT_YCBCR422;
+
+	if (is_rockchip(dp->plat_data->dev_type)) {
+		if ((di->color_formats & mask)) {
+			DRM_DEBUG_KMS("Swapping display color format from YUV to RGB\n");
+			di->color_formats &= ~mask;
+			di->color_formats |= DRM_COLOR_FORMAT_RGB444;
+			di->bpc = 8;
+		}
+	}
```

**Concerns:**
1. **Locking:** Direct modification of `connector->display_info` without visible locking. The display_info is typically populated during probe/hotplug and shouldn't be modified during atomic check.
2. **Atomic property:** This modifies connector state outside of atomic state management. Should this be in connector state instead?
3. **Side effects in check:** atomic_check should be read-only validation, not modify hardware/driver state

**This is potentially unsafe and violates atomic modesetting principles.**

**Suggested fix:** Move to a different callback or properly handle via atomic state.

**Verdict:** **NEEDS REVISION** - Modifying display_info in atomic_check is incorrect.

---

---
Generated by Claude Code Patch Reviewer