From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: use core library's CStr instead of kernel one Date: Tue, 17 Feb 2026 15:48:08 +1000 Message-ID: In-Reply-To: <20260217-nova-misc-v3-7-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> <20260217-nova-misc-v3-7-b4e2d45eafbc@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes three files to use `core::ffi::CStr` instead of `kernel::str::CStr`. In the `elf` submodule of `firmware/gsp.rs`, the `kernel::prelude::*` import is replaced with a targeted import of just `kernel::bindings` and `kernel::transmute::FromBytes`, while `CStr` and `size_of` come from `core` directly. > + use core::{ > + ffi::CStr, > + mem::size_of, // > + }; > + > use kernel::{ > bindings, > - prelude::*, > transmute::FromBytes, // > }; The removal of `prelude::*` in the `elf` submodule is fine since the only thing the submodule used from the prelude was `CStr` (the submodule doesn't use `Result`, `Vec`, or other prelude items, as confirmed by inspecting the code). `size_of` was already imported via `core::mem::size_of` in the existing code. No issues found. --- Generated by Claude Code Patch Reviewer