From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: gsp: add command_size helper
Date: Fri, 27 Feb 2026 12:21:59 +1000
Message-ID: <review-patch7-20260226-cmdq-continuation-v3-7-572ab9916766@nvidia.com>
In-Reply-To: <20260226-cmdq-continuation-v3-7-572ab9916766@nvidia.com>
References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> <20260226-cmdq-continuation-v3-7-572ab9916766@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Extracts the `size_of::<M::Command>() + command.variable_payload_len()` calculation into a standalone `command_size()` function. This is used in the existing `send_command` and will be reused in patch 8's `SplitState::new()`.

```rust
fn command_size<M>(command: &M) -> usize
where
    M: CommandToGsp,
{
    size_of::<M::Command>() + command.variable_payload_len()
}
```

Clean factoring. No issues.

---
Generated by Claude Code Patch Reviewer