From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: lib/fonts: Store font data as font_data_t; update consoles
Date: Tue, 03 Mar 2026 13:19:15 +1000
Message-ID: <review-patch7-20260302141255.518657-8-tzimmermann@suse.de>
In-Reply-To: <20260302141255.518657-8-tzimmermann@suse.de>
References: <20260302141255.518657-1-tzimmermann@suse.de> <20260302141255.518657-8-tzimmermann@suse.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

This is the most substantial structural change. Introduces `font_data_t` as a typedef for `const unsigned char`, documents the hidden header layout, changes `struct font_desc.data` and `struct fbcon_display.fontdata` to `font_data_t *`, and adds the `font_data_buf()` accessor.

The hidden header documentation is excellent and very helpful:
```c
 * +------+-----------------------------+
 * | -16  |  CRC32 Checksum (optional)  |
 * | -12  |  <Unused>                   |
 * |  -8  |  Number of data bytes       |
 * |  -4  |  Reference count            |
 * +------+-----------------------------+
 * |   0  |  Data buffer                |
```

Minor documentation typos:
- `"fotn data"` should be `"font data"`
- `"characer count"` should be `"character count"`

The condition change in `fbcon_set_disp()` from `if (!vc->vc_font.data)` to `if (!p->fontdata)` is semantically correct since `p->fontdata` is now the authoritative source and `vc_font.data` is derived from it.

---
Generated by Claude Code Patch Reviewer