From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: cma: Turn the heap into a module
Date: Wed, 04 Mar 2026 07:41:36 +1000 [thread overview]
Message-ID: <review-patch7-20260303-dma-buf-heaps-as-modules-v3-7-24344812c707@kernel.org> (raw)
In-Reply-To: <20260303-dma-buf-heaps-as-modules-v3-7-24344812c707@kernel.org>
Patch Review
Changes `DMABUF_HEAPS_CMA` from `bool` to `tristate` and adds the `MODULE_LICENSE`, `MODULE_IMPORT_NS("DMA_BUF")`, and `MODULE_IMPORT_NS("DMA_BUF_HEAP")` macros.
The commit message correctly notes that unloading is not supported. The `__init` annotation on `add_cma_heaps()` and `__add_cma_heap()` is fine — for modules, `__init` functions are freed after `module_init()` completes.
**Minor observation:** There is no `module_exit()` function, which means the module cannot be unloaded. This is mentioned in the commit message, which is good. However, it might be worth adding an explicit comment in the code itself, or using something like `permanent_request_module()` / a comment explaining why no exit function is provided, to prevent future confusion.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 21:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 10:13 [PATCH v3 0/8] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-03-03 10:13 ` [PATCH v3 1/8] dma: contiguous: Turn heap registration logic around Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 ` [PATCH v3 2/8] dma: contiguous: Make dev_get_cma_area() a proper function Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 ` [PATCH v3 3/8] dma: contiguous: Make dma_contiguous_default_area static Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 ` [PATCH v3 4/8] dma: contiguous: Export dev_get_cma_area() Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 ` [PATCH v3 5/8] mm: cma: Export cma_alloc(), cma_release() and cma_get_name() Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 ` [PATCH v3 6/8] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 ` [PATCH v3 7/8] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-03-03 21:41 ` Claude Code Review Bot [this message]
2026-03-03 10:13 ` [PATCH v3 8/8] dma-buf: heaps: system: " Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
2026-03-03 21:41 ` Claude review: dma-buf: heaps: Turn heaps into modules Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-02-25 16:41 [PATCH 0/7] " Maxime Ripard
2026-02-25 16:41 ` [PATCH 6/7] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch7-20260303-dma-buf-heaps-as-modules-v3-7-24344812c707@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox