From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: heaps: cma: Turn the heap into a module Date: Wed, 04 Mar 2026 07:41:36 +1000 Message-ID: In-Reply-To: <20260303-dma-buf-heaps-as-modules-v3-7-24344812c707@kernel.org> References: <20260303-dma-buf-heaps-as-modules-v3-0-24344812c707@kernel.org> <20260303-dma-buf-heaps-as-modules-v3-7-24344812c707@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Changes `DMABUF_HEAPS_CMA` from `bool` to `tristate` and adds the `MODULE_L= ICENSE`, `MODULE_IMPORT_NS("DMA_BUF")`, and `MODULE_IMPORT_NS("DMA_BUF_HEAP= ")` macros. The commit message correctly notes that unloading is not supported. The `__= init` annotation on `add_cma_heaps()` and `__add_cma_heap()` is fine =E2=80= =94 for modules, `__init` functions are freed after `module_init()` complet= es. **Minor observation:** There is no `module_exit()` function, which means th= e module cannot be unloaded. This is mentioned in the commit message, which= is good. However, it might be worth adding an explicit comment in the code= itself, or using something like `permanent_request_module()` / a comment e= xplaining why no exit function is provided, to prevent future confusion. --- Generated by Claude Code Patch Reviewer