public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dpu: Add support for Eliza SoC
Date: Thu, 05 Mar 2026 13:31:11 +1000	[thread overview]
Message-ID: <review-patch7-20260304-drm-display-eliza-v2-7-ea0579f62358@oss.qualcomm.com> (raw)
In-Reply-To: <20260304-drm-display-eliza-v2-7-ea0579f62358@oss.qualcomm.com>

Patch Review

This is the main catalog patch (DPU v12.4). One issue:

**Bug: `eliza_cwb` defined but not used.** At lines 2531-2532:
```c
.cwb_count = ARRAY_SIZE(eliza_cwb),
.cwb = sm8650_cwb,
```

The patch defines `eliza_cwb[]` with `.len = 0x20` for each entry (lines 2419-2436), but the `dpu_eliza_cfg` struct references `sm8650_cwb` which has `.len = 0x8`. This makes `eliza_cwb` dead code. The correct CWB len for Eliza is likely `0x20` (matching `sm8750_cwb` which also has `0x20`), so this should be:
```c
.cwb = eliza_cwb,
```

Note: this mirrors a pre-existing bug in `dpu_12_0_sm8750.h:485-486` where `sm8750_cwb` is defined with `.len = 0x20` but `.cwb = sm8650_cwb` is used. That should also be fixed separately.

Other observations on this patch:
- **TODO at line 2495**: `/* TODO: macrotile-qseed is different from macrotile */` in `eliza_perf_data.qos_lut_tbl` — the QoS LUT table reuses `sc7180_qos_*` entries. This may need tuning for production but is reasonable for initial bringup.
- The `sm8650_vbif` reuse (line 2535-2536) follows the same pattern as SM8750 and Glymur.
- DSC has only 3 entries (DSC_0, DSC_1, DSC_2) vs 4 on SM8750, consistent with fewer blocks on Eliza.
- LM_3 at line 2298 intentionally has no `.dspp` assignment (only 3 DSPPs for 4 LMs), which is a valid configuration.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-05  3:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 12:58 [PATCH v2 0/8] drm/msm: Add Qualcomm Eliza SoC support Krzysztof Kozlowski
2026-03-04 12:58 ` [PATCH v2 1/8] dt-bindings: display/msm: dp-controller: Add Eliza SoC Krzysztof Kozlowski
2026-03-04 14:29   ` Dmitry Baryshkov
2026-03-05  3:31   ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 2/8] dt-bindings: display/msm: dsi-phy-7nm: " Krzysztof Kozlowski
2026-03-05  3:31   ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 3/8] dt-bindings: display/msm: dsi-controller-main: " Krzysztof Kozlowski
2026-03-05  3:31   ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 4/8] dt-bindings: display/msm: qcom,sm8650-dpu: " Krzysztof Kozlowski
2026-03-05  3:31   ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 5/8] dt-bindings: display/msm: qcom,eliza-mdss: " Krzysztof Kozlowski
2026-03-05  3:31   ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 6/8] soc: qcom: ubwc: Add configuration " Krzysztof Kozlowski
2026-03-04 13:35   ` Konrad Dybcio
2026-03-04 14:03     ` Krzysztof Kozlowski
2026-03-04 13:58   ` Dmitry Baryshkov
2026-03-05  3:31   ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 7/8] drm/msm/dpu: Add support for " Krzysztof Kozlowski
2026-03-04 14:29   ` Dmitry Baryshkov
2026-03-05  3:31   ` Claude Code Review Bot [this message]
2026-03-04 12:58 ` [PATCH v2 8/8] drm/msm/mdss: " Krzysztof Kozlowski
2026-03-05  3:31   ` Claude review: " Claude Code Review Bot
2026-03-05  3:31 ` Claude review: drm/msm: Add Qualcomm Eliza SoC support Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-03 13:07 [PATCH 0/8] " Krzysztof Kozlowski
2026-03-03 13:07 ` [PATCH 7/8] drm/msm/dpu: Add support for Eliza SoC Krzysztof Kozlowski
2026-03-03 21:15   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch7-20260304-drm-display-eliza-v2-7-ea0579f62358@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox