From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: synopsys: dw-dp: Unregister AUX channel on bridge detach Date: Tue, 10 Mar 2026 11:47:02 +1000 Message-ID: In-Reply-To: <20260310-drm-rk-fixes-v2-7-645ecfb43f49@collabora.com> References: <20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com> <20260310-drm-rk-fixes-v2-7-645ecfb43f49@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Good** The AUX channel is registered in `dw_dp_bind()` via `drm_dp_aux_register()` but was never unregistered, leading to a use-after-free when the module is reloaded (as demonstrated by the KASAN trace in the commit message). Adding `drm_dp_aux_unregister()` in a `bridge_detach` callback is the correct place for this cleanup, as it's the symmetric counterpart to registration happening during bind (which triggers bridge attach). ```c +static void dw_dp_bridge_detach(struct drm_bridge *bridge) +{ + struct dw_dp *dp = bridge_to_dp(bridge); + drm_dp_aux_unregister(&dp->aux); +} ``` The `Fixes:` tag references the correct commit. Good fix. --- Generated by Claude Code Patch Reviewer