From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Date: Tue, 10 Mar 2026 11:39:08 +1000 Message-ID: In-Reply-To: <20260310012458.169272-8-damon.ding@rock-chips.com> References: <20260310012458.169272-1-damon.ding@rock-chips.com> <20260310012458.169272-8-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves the YUV-to-RGB color format override from `rockchip_dp_get_modes()` to `analogix_dp_atomic_check()`. The logic is guarded by `is_rockchip()`. One concern: Modifying `display_info` in `atomic_check` is somewhat unusual. `display_info` is typically populated during EDID parsing and is not expected to change during atomic check. This works but is a mild layering violation. The original code in `get_modes` had the same issue, so this doesn't introduce a new problem. ```c if (is_rockchip(dp->plat_data->dev_type)) { if ((di->color_formats & mask)) { ``` The double parentheses `((di->color_formats & mask))` are unnecessary but harmless. --- Generated by Claude Code Patch Reviewer