From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Account for AS_SDP guardband only when enabled Date: Thu, 12 Mar 2026 06:55:29 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-8-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-8-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Removes the `assume_all_enabled && HAS_AS_SDP(display)` check and only acco= unts for AS SDP guardband when it's actually enabled in `crtc_state->infofr= ames.enable`. **Concern:** The `assume_all_enabled` parameter was presumably there for a = reason =E2=80=94 to conservatively compute guardbands during early configur= ation when individual SDP enables aren't yet known. By removing the AS SDP = case from the `assume_all_enabled` path, this could under-count guardbands = in scenarios where `assume_all_enabled=3Dtrue` is passed. However, patch 19= later always enables AS SDP when supported, which may compensate. The orde= ring here means there's a window between patches 7 and 19 where guardbands = could be under-counted. --- Generated by Claude Code Patch Reviewer