From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/mdss: use qcom_ubwc_version_tag() helper Date: Fri, 13 Mar 2026 14:12:50 +1000 Message-ID: In-Reply-To: <20260312-ubwc-rework-v3-7-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> <20260312-ubwc-rework-v3-7-b7e8f800176a@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces the inlined version ladder with `qcom_ubwc_version_tag(data)`. Clean. ### PATCHES 8-9: use new helper to set min_acc length (adreno + mdss) Mechanical switch from direct field access / per-GPU checks to `qcom_ubwc_min_acc_length_64b()`. The old a610/a702 GPU-specific checks are replaced with UBWC version-based logic, which is the correct abstraction. ### PATCHES 10-11: use new helper to set macrotile_mode (adreno + mdss) Mechanical switch from `data->macrotile_mode` to `qcom_ubwc_macrotile_mode(data)`. --- Generated by Claude Code Patch Reviewer