From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Date: Sun, 22 Mar 2026 04:35:46 +1000 Message-ID: In-Reply-To: <20260319071452.1961274-8-damon.ding@rock-chips.com> References: <20260319071452.1961274-1-damon.ding@rock-chips.com> <20260319071452.1961274-8-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves the YUV-to-RGB color format override from `rockchip_dp_get_modes()` to `analogix_dp_atomic_check()`. This is architecturally better since `atomic_check` is the proper place for such constraints. **Concern**: Modifying `display_info` in `atomic_check` is a side-effect that persists across atomic checks. This is how the original code worked too (modifying it in `get_modes`), so it's not a regression, but it's worth noting that this modifies connector state outside of an atomic commit. This is an existing design issue, not introduced by this patch. No blocking issues. --- Generated by Claude Code Patch Reviewer