From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Rename and simplify is_rockchip() Date: Sun, 22 Mar 2026 04:26:16 +1000 Message-ID: In-Reply-To: <20260319104031.1986946-8-damon.ding@rock-chips.com> References: <20260319104031.1986946-1-damon.ding@rock-chips.com> <20260319104031.1986946-8-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The rename from `is_rockchip()` to `analogix_dp_is_rockchip()` improves namespace consistency. The switch-based implementation is cleaner and makes adding new Rockchip variants easier (no need to extend a chain of `||`). This is a clean mechanical change. The `Suggested-by` tag crediting Nicolas Frattaroli is noted. One nit: `Suggested-by` should conventionally appear before `Signed-off-by` in the commit message, not after. Currently: ``` Signed-off-by: Damon Ding Suggested-by: Nicolas Frattaroli ``` --- Generated by Claude Code Patch Reviewer