From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: convert Gsp::new() to use CoherentBox
Date: Sun, 22 Mar 2026 03:23:44 +1000 [thread overview]
Message-ID: <review-patch7-20260320194626.36263-8-dakr@kernel.org> (raw)
In-Reply-To: <20260320194626.36263-8-dakr@kernel.org>
Patch Review
Converts `libos` and `rmargs` initialization to use `CoherentBox` and `Coherent::init()` respectively.
**Ordering concern in `try_pin_init!`**: The new code initializes fields in this order:
```rust
loginit: LogBuffer::new(dev)?,
logintr: LogBuffer::new(dev)?,
logrm: LogBuffer::new(dev)?,
cmdq <- Cmdq::new(dev),
rmargs: Coherent::init(dev, GFP_KERNEL, GspArgumentsPadded::new(&cmdq))?,
libos: { ... libos.init_at(3, ..., rmargs)? ... libos.into() },
```
The `libos` initialization at element 3 references `rmargs` — this works because within `try_pin_init!`, earlier field bindings are accessible to later fields. The `rmargs` reference used in `LibosMemoryRegionInitArgument::new("RMARGS", rmargs)` is a `&Coherent<GspArgumentsPadded>`. This should work since `rmargs` has been initialized by that point in the macro expansion.
**`MessageQueueInitArguments` type alias change**: Changed from a newtype `struct MessageQueueInitArguments(bindings::MESSAGE_QUEUE_INIT_ARGUMENTS)` to a plain type alias `type MessageQueueInitArguments = bindings::MESSAGE_QUEUE_INIT_ARGUMENTS`. Then `impl MessageQueueInitArguments` adds a `new()` method returning `impl Init<Self>`. This is a clean simplification since the wrapper served no purpose beyond the constructor.
The `#[allow(non_snake_case)]` on the `new` function for `MessageQueueInitArguments` is needed since the `init!` macro generates bindings for the camelCase fields.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 17:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 19:45 [PATCH v2 0/8] dma::Coherent & dma::CoherentBox API Danilo Krummrich
2026-03-20 19:45 ` [PATCH v2 1/8] rust: dma: use "kernel vertical" style for imports Danilo Krummrich
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 2/8] rust: dma: add generalized container for types other than slices Danilo Krummrich
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 3/8] rust: dma: add zeroed constructor to `Coherent` Danilo Krummrich
2026-03-21 6:37 ` Alexandre Courbot
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 4/8] rust: dma: introduce dma::CoherentBox for memory initialization Danilo Krummrich
2026-03-20 20:55 ` Gary Guo
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 5/8] rust: dma: add Coherent:init() and Coherent::init_with_attrs() Danilo Krummrich
2026-03-20 20:56 ` Gary Guo
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 6/8] gpu: nova-core: use Coherent::init to initialize GspFwWprMeta Danilo Krummrich
2026-03-20 21:04 ` Gary Guo
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-20 19:45 ` [PATCH v2 7/8] gpu: nova-core: convert Gsp::new() to use CoherentBox Danilo Krummrich
2026-03-20 21:06 ` Gary Guo
2026-03-21 17:23 ` Claude Code Review Bot [this message]
2026-03-20 19:45 ` [PATCH v2 8/8] gpu: nova-core: convert to new dma::Coherent API Danilo Krummrich
2026-03-21 16:50 ` Gary Guo
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
2026-03-21 5:13 ` [PATCH v2 0/8] dma::Coherent & dma::CoherentBox API Alexandre Courbot
2026-03-21 17:23 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch7-20260320194626.36263-8-dakr@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox