From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: falcon: introduce `bounded_enum` macro
Date: Wed, 25 Mar 2026 07:57:35 +1000 [thread overview]
Message-ID: <review-patch7-20260323-b4-nova-register-v3-7-ae2486ecef1b@nvidia.com> (raw)
In-Reply-To: <20260323-b4-nova-register-v3-7-ae2486ecef1b@nvidia.com>
Patch Review
This introduces the `bounded_enum!` macro that generates:
- An enum with `Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord` derives
- `From<EnumType> for Bounded<W, L>`
- Either `TryFrom<Bounded<W, L>> for EnumType` or `From<Bounded<W, L>> for EnumType`
The `From` variant (for exhaustive enums) uses `build_error!` for uncovered values — this will be changed to `MAX.. => unreachable!()` in patch 8. The macro is marked `#[expect(unused)]` here since it's only used in the next patch.
Good separation for reviewability.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 11:07 [PATCH v3 00/10] gpu: nova-core: convert registers to use the kernel register macro Alexandre Courbot
2026-03-23 11:07 ` [PATCH v3 01/10] gpu: nova-core: convert PMC registers to " Alexandre Courbot
2026-03-23 11:21 ` Danilo Krummrich
2026-03-23 14:11 ` Alexandre Courbot
2026-03-23 14:21 ` Danilo Krummrich
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
2026-03-23 11:07 ` [PATCH v3 02/10] gpu: nova-core: convert PBUS " Alexandre Courbot
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
2026-03-23 11:07 ` [PATCH v3 03/10] gpu: nova-core: convert PFB " Alexandre Courbot
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
2026-03-23 11:07 ` [PATCH v3 04/10] gpu: nova-core: convert GC6 " Alexandre Courbot
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
2026-03-23 11:07 ` [PATCH v3 05/10] gpu: nova-core: convert FUSE " Alexandre Courbot
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
2026-03-23 11:07 ` [PATCH v3 06/10] gpu: nova-core: convert PDISP " Alexandre Courbot
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
2026-03-23 11:07 ` [PATCH v3 07/10] gpu: nova-core: falcon: introduce `bounded_enum` macro Alexandre Courbot
2026-03-23 11:22 ` Danilo Krummrich
2026-03-23 12:43 ` Gary Guo
2026-03-23 14:22 ` Alexandre Courbot
2026-03-24 21:57 ` Claude Code Review Bot [this message]
2026-03-23 11:07 ` [PATCH v3 08/10] gpu: nova-core: convert falcon registers to kernel register macro Alexandre Courbot
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
2026-03-23 11:07 ` [PATCH v3 09/10] gpu: nova-core: remove `io::` qualifier to register macro invocations Alexandre Courbot
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
2026-03-23 11:07 ` [PATCH v3 10/10] Documentation: nova: remove register abstraction task Alexandre Courbot
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
2026-03-24 21:57 ` Claude review: gpu: nova-core: convert registers to use the kernel register macro Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-20 12:19 [PATCH v2 00/10] " Alexandre Courbot
2026-03-20 12:19 ` [PATCH v2 07/10] gpu: nova-core: falcon: introduce `bounded_enum` macro Alexandre Courbot
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch7-20260323-b4-nova-register-v3-7-ae2486ecef1b@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox