From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: falcon: introduce `bounded_enum` macro
Date: Wed, 25 Mar 2026 07:57:35 +1000
Message-ID: <review-patch7-20260323-b4-nova-register-v3-7-ae2486ecef1b@nvidia.com>
In-Reply-To: <20260323-b4-nova-register-v3-7-ae2486ecef1b@nvidia.com>
References: <20260323-b4-nova-register-v3-0-ae2486ecef1b@nvidia.com> <20260323-b4-nova-register-v3-7-ae2486ecef1b@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

This introduces the `bounded_enum!` macro that generates:
- An enum with `Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord` derives
- `From<EnumType> for Bounded<W, L>`=20
- Either `TryFrom<Bounded<W, L>> for EnumType` or `From<Bounded<W, L>> for =
EnumType`

The `From` variant (for exhaustive enums) uses `build_error!` for uncovered=
 values =E2=80=94 this will be changed to `MAX.. =3D> unreachable!()` in pa=
tch 8. The macro is marked `#[expect(unused)]` here since it's only used in=
 the next patch.

Good separation for reviewability.

---
Generated by Claude Code Patch Reviewer