From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: Add MMU address space registers Date: Wed, 25 Mar 2026 07:08:43 +1000 Message-ID: In-Reply-To: <20260323-b4-tyr-use-register-macro-v3-v3-7-a87daf9e4701@collabora.com> References: <20260323-b4-tyr-use-register-macro-v3-v3-0-a87daf9e4701@collabora.com> <20260323-b4-tyr-use-register-macro-v3-v3-7-a87daf9e4701@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces the per-address-space registers with `[MAX_AS, stride = STRIDE]` array syntax. The stride of 0x40 (64 bytes) and base offset of 0x2400 match the Mali MMU AS register layout. The `STATUS` register correctly uses `=> bool` for the single-bit `active_ext` and `active_int` flags. --- Generated by Claude Code Patch Reviewer