From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ast: Use constants for WDT registers
Date: Wed, 25 Mar 2026 07:46:40 +1000
Message-ID: <review-patch7-20260323160407.245773-8-tzimmermann@suse.de>
In-Reply-To: <20260323160407.245773-8-tzimmermann@suse.de>
References: <20260323160407.245773-1-tzimmermann@suse.de> <20260323160407.245773-8-tzimmermann@suse.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Good use of parameterized macros for the watchdog timer registers:
```c
#define AST_REG_WDT_BASE(__n)   (0x1e785000 + (__n) * 0x40)
#define AST_REG_WDT(__n, __offset) (AST_REG_WDT_BASE((__n)) + (__offset))
```

The WDT register spacing of 0x40 bytes per timer instance is cleanly abstracted. Verified the old addresses map correctly: WDT1 at 0x1e785040+ matches `AST_REG_WDT*(1)`.

---
Generated by Claude Code Patch Reviewer