From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi-state-helper: Try subsampling in mode_valid Date: Wed, 25 Mar 2026 06:44:27 +1000 Message-ID: In-Reply-To: <20260324-color-format-v11-7-605559af4fb4@collabora.com> References: <20260324-color-format-v11-0-605559af4fb4@collabora.com> <20260324-color-format-v11-7-605559af4fb4@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review 1. **420-also modes always checked with YCbCr420:** The `drm_hdmi_connector= _mode_valid` now uses `DRM_OUTPUT_COLOR_FORMAT_YCBCR420` for 420-also modes= when `ycbcr_420_allowed` is set. This means the mode is validated at YCbCr= 420's lower clock (half pixel clock), which could make modes appear valid t= hat would fail in RGB. Since mode_valid is meant to be permissive (the actu= al format is decided later in atomic_check), this is acceptable =E2=80=94 b= ut it changes behavior for existing setups: modes that were previously reje= cted (because they exceeded the RGB clock limit) will now be listed as vali= d if 420-also. This is a conscious design decision and is reasonable =E2=80=94 the commit = message explains the rationale well. --- Generated by Claude Code Patch Reviewer