From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: Update check to skip prepare_job() for fragment jobs Date: Tue, 31 Mar 2026 17:33:25 +1000 Message-ID: In-Reply-To: <20260330-job-submission-fixes-cleanup-v1-7-7de8c09cef8c@imgtec.com> References: <20260330-job-submission-fixes-cleanup-v1-0-7de8c09cef8c@imgtec.com> <20260330-job-submission-fixes-cleanup-v1-7-7de8c09cef8c@imgtec.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status**: Correct, minor optimization. Changes from `job->paired_job->has_pm_ref` to `job->has_pm_ref`. Looking at `pvr_queue_run_job()` (line 776-779), both the geometry job and its paired fragment job get PM refs during `run_job()`: ```c err = pvr_job_get_pm_ref(job); ... if (job->paired_job) { err = pvr_job_get_pm_ref(job->paired_job); ``` So checking `job->has_pm_ref` (the fragment job itself) is equivalent and avoids a pointer dereference to the paired geometry job which might have already completed and released its PM ref by the time `prepare_job()` is called again on the fragment job. **No issues.** --- Generated by Claude Code Patch Reviewer