From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Account for AS_SDP guardband only when enabled Date: Tue, 31 Mar 2026 17:39:46 +1000 Message-ID: In-Reply-To: <20260330040656.4116502-8-ankit.k.nautiyal@intel.com> References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-8-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Concern:** This patch removes the `assume_all_enabled` path for AS SDP gu= ardband: ```c - if ((assume_all_enabled && HAS_AS_SDP(display)) || - crtc_state->infoframes.enable & intel_hdmi_infoframe_enable(DP_SDP_AD= APTIVE_SYNC)) + if (crtc_state->infoframes.enable & + intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC)) ``` The `assume_all_enabled` parameter is used by callers that need worst-case = guardband estimates. By removing the AS SDP case from this path, those call= ers may underestimate the guardband. This is presumably intentional because= patch 19 will always enable AS SDP when supported, but between patches 7 a= nd 19 there could be a regression window. No R-b tag. Also removes the `display` variable but doesn't note this is a side effect = =E2=80=94 minor style nit. --- Generated by Claude Code Patch Reviewer