Claude review: drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late

Claude Code Review Bot
2026-03-31T07:39:49Z

Patch Review

Good architectural split. The early phase (`intel_dp_compute_as_sdp`) sets only the infoframe enable bit so guardband can account for it. The late phase (`intel_dp_as_sdp_compute_config_late`) fills in the actual SDP fields after other features are resolved.

The check using bitwise AND needs parentheses for clarity (though it works correctly due to `== 0` precedence):
```c
+ if ((crtc_state->infoframes.enable &
+ intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC)) == 0)
```
This is fine. No R-b tag.

---
Generated by Claude Code Patch Reviewer