Claude review: drm/i915/display: Add helper for AS SDP transmission time selection

Claude Code Review Bot
2026-03-31T07:39:48Z

Patch Review

The helper `intel_dp_as_sdp_transmission_time()` takes no arguments and always returns `DP_PR_AS_SDP_SETUP_TIME_T1` (which is `(0 << 6)` = 0). This is a bit over-engineered for a constant zero return, but it documents the intent and makes future changes easier.

The `get_pr_alpm_as_sdp_transmission_time()` function in intel_alpm.c takes a `crtc_state` parameter but doesn't use it — the called function takes no arguments. Minor dead parameter. No R-b tag.

**Nit:** `#include "intel_display_utils.h"` is added in intel_alpm.c but it's unclear this header is needed — `MISSING_CASE` likely comes from another header already included.

---
Generated by Claude Code Patch Reviewer