Claude review: drm/i915/dp: Account for AS_SDP guardband only when enabled

Claude Code Review Bot
2026-04-12T02:51:27Z

Patch Review

**R-b: Ville Syrjala**

Removes the `assume_all_enabled && HAS_AS_SDP(display)` path from the AS SDP guardband calculation, now only considering AS SDP if it's actually enabled in `crtc_state->infoframes.enable`.

This drops the `struct intel_display *display` variable entirely since it's no longer needed. The logic change means that when `assume_all_enabled` is true (used during guardband precomputation), AS SDP is no longer speculatively accounted for. This is intentional -- later patches (26) ensure AS SDP is always enabled when it could be needed.

However, there's a sequencing concern: between this patch and patch 26, the guardband might be underestimated for configurations that have AS SDP capability but haven't yet enabled it. In a bisection between patches 10 and 26, this could theoretically cause problems. Worth noting but likely acceptable given the series is intended to land as a unit.

---
Generated by Claude Code Patch Reviewer