Claude review: Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM

Claude Code Review Bot
2026-03-31T07:39:44Z

Overall Series Review

Subject: Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM
Author: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Patches: 33
Reviewed: 2026-03-31T17:39:44.871086

---

This 19-patch series adds Adaptive Sync SDP support for Panel Replay with Link ON and Auxless ALPM (Link-Off) configurations, building on existing AS SDP infrastructure. The series is well-structured: patches 1-5 are cleanup/fixes to existing code, patches 6-11 add guardrails and correctness improvements, patches 12-13 add infrastructure, and patches 14-19 implement the new functionality.

The series has good review coverage from Ville Syrjälä on many patches. The overall architecture of splitting AS SDP computation into early (enable flag for guardband) and late (actual fields) phases is sound.

**Key concerns:**
1. **Bug in patch 12**: `drm_dp_dpcd_read_byte()` returns 0 on success, not 1. The series checks `== 1`, which will always fail.
2. **Patch 7 changes `assume_all_enabled` semantics** without updating all callers — this could cause regressions in guardband calculations.
3. **Patch 15 extends the burst write to 3 bytes** but assumes PANEL_REPLAY_CONFIG3 is at offset 0x1b2 (contiguous with CONFIG/CONFIG2) — this should be verified against the spec, as PANEL_REPLAY_CONFIG3 was defined at 0x11a in patch 4.

---

---
Generated by Claude Code Patch Reviewer