Claude review: drm/i915/dp: Always enable AS SDP if supported by source + sink

Claude Code Review Bot
2026-03-31T07:39:49Z

Patch Review

Changes `intel_dp_can_use_as_sdp()` to return `true` whenever source + sink support it (removing the `vrr.enable` requirement). This is the payoff for the entire series — AS SDP is always active so it's available for PR, CMRR, etc. without triggering modesets.

Combined with patch 18's late computation, the `mode` field will correctly be set to `DP_AS_SDP_AVT_FIXED_VTOTAL` when neither VRR nor CMRR is enabled. No R-b tag but the change itself is trivial.

---

**Summary of items needing attention:**
1. **Patch 12 (bug):** `drm_dp_dpcd_read_byte()` returns 0 on success, not 1 — AS SDP v2 detection is broken.
2. **Patch 4 + 15 (inconsistency):** PANEL_REPLAY_CONFIG3 at 0x11a vs burst write to 0x1b0+2=0x1b2 — one of these is wrong.
3. **Patch 7:** Removing `assume_all_enabled` for AS SDP guardband could cause issues between patches 7 and 19.

---
Generated by Claude Code Patch Reviewer