From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: heaps: cma: Turn the heap into a module Date: Wed, 01 Apr 2026 07:50:37 +1000 Message-ID: In-Reply-To: <20260331-dma-buf-heaps-as-modules-v4-7-e18fda504419@kernel.org> References: <20260331-dma-buf-heaps-as-modules-v4-0-e18fda504419@kernel.org> <20260331-dma-buf-heaps-as-modules-v4-7-e18fda504419@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes `DMABUF_HEAPS_CMA` from `bool` to `tristate`, adds `MODULE_LICENSE("GPL")`, and imports `DMA_BUF` and `DMA_BUF_HEAP` namespaces. The patch also changes `__init` to `module_init` -- wait, looking again, the function `add_cma_heaps` was already using `module_init()` macro in the existing code (`module_init(add_cma_heaps)`). But the function is still declared `static int __init add_cma_heaps(void)`. When built as a module, `__init` becomes a section annotation that is fine for module init functions, so this is correct. **No module_exit:** The commit message explicitly states "This heap won't be able to unload though, since we're missing a lot of infrastructure to make it safe." This is acceptable for now -- modules without `module_exit` cannot be unloaded. However, this means `rmmod` will fail with `EBUSY` or similar. This is a deliberate design choice documented in the commit message. No issues. --- Generated by Claude Code Patch Reviewer