From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: imx8mq: Add DCSS + HDMI/DP display pipeline
Date: Sun, 12 Apr 2026 13:34:46 +1000
Message-ID: <review-patch7-20260407-dcss-hdmi-upstreaming-v21-7-4681070ab82f@oss.nxp.com>
In-Reply-To: <20260407-dcss-hdmi-upstreaming-v21-7-4681070ab82f@oss.nxp.com>
References: <20260407-dcss-hdmi-upstreaming-v21-0-4681070ab82f@oss.nxp.com> <20260407-dcss-hdmi-upstreaming-v21-7-4681070ab82f@oss.nxp.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**PHY and bridge share the same reg address:**
```dts
mdhp_phy: phy@32c00000 {
    reg = <0x32c00000 0x100000>;
};

mhdp: bridge@32c00000 {
    reg = <0x32c00000 0x100000>;
};
```
Two nodes with the same `reg` will fail `dtbs_check` and is technically incorrect. If they truly share the same MMIO space, the typical pattern is either a syscon node, or one node with sub-resources. This needs resolution.

**Typo in node name**: `mdhp_phy` should be `mhdp_phy` (transposed 'd' and 'h').

**Missing `cdns,bridge-type`**: The `mhdp` node in the SoC dtsi doesn't set `cdns,bridge-type`, relying on board files to provide it. But the binding marks it as required, so this DTS will fail validation. It should either be set per-board (which it is in patch 8) via an override, or the property should not be required in the binding.

**`mhdp_out` endpoint is empty:**
```dts
port@1 {
    reg = <1>;
    mhdp_out: endpoint {
    };
};
```
An empty endpoint without `remote-endpoint` or `data-lanes` is unusual. Board-level DTS overrides it in patch 8 but the SoC-level node still has an incomplete endpoint that won't pass binding validation (missing required `data-lanes`).

---
Generated by Claude Code Patch Reviewer