From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: Switch to managed for encoder Date: Sun, 12 Apr 2026 10:51:25 +1000 Message-ID: In-Reply-To: <20260409-feat_link_cap-v1-7-7069e8199ce2@bootlin.com> References: <20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com> <20260409-feat_link_cap-v1-7-7069e8199ce2@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The conversion to `drmm_encoder_alloc()` / `drmm_encoder_init()` / `drmm_kzalloc()` is correct. The use of `drmm_add_action_or_reset()` for encoder-specific cleanup (DP flush work, TypeC port cleanup, SDVO i2c cleanup, DVO device ops) is appropriate. **Issue:** Several error paths in this patch drop `kfree(intel_connector)` calls (e.g., in `g4x_dp.c` and `g4x_hdmi.c`) without connectors being managed yet. Connectors don't become managed until patch 8. If this patch is applied without patch 8 and an error occurs during init, the connector allocation will leak. These two patches should either be squashed or the connector cleanup should be retained in patch 7. --- Generated by Claude Code Patch Reviewer