From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Date: Sun, 12 Apr 2026 11:37:40 +1000 Message-ID: In-Reply-To: <20260409065301.446670-8-damon.ding@rock-chips.com> References: <20260409065301.446670-1-damon.ding@rock-chips.com> <20260409065301.446670-8-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves the YUV-to-RGB color format fixup from `rockchip_dp_get_modes()` into `analogix_dp_atomic_check()`, gated by `is_rockchip()`. This makes the check run at atomic_check time rather than get_modes time, which is architecturally more appropriate. One minor concern: modifying `display_info` (which lives on the connector, not in state) from `atomic_check` is a bit unusual. The `display_info` is typically populated during EDID parsing and is not per-state. However, this pattern was already present in the original code (just in `get_modes()` instead), so this isn't a regression. The bridge `atomic_check` in patch 11 continues this approach. No blocking issues. --- Generated by Claude Code Patch Reviewer