From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Use a local iomem base for firmware control registers Date: Mon, 13 Apr 2026 19:05:53 +1000 Message-ID: In-Reply-To: <20260412142951.2309135-8-karunika.choo@arm.com> References: <20260412142951.2309135-1-karunika.choo@arm.com> <20260412142951.2309135-8-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Good. Acked-by Boris Brezillon.** Adds `void __iomem *iomem` to `struct panthor_fw`, set to `ptdev->iomem + MCU_CONTROL_BASE` (0x700): ```c + fw->iomem = ptdev->iomem + MCU_CONTROL_BASE; ``` Register defines are rebased relative to MCU_CONTROL_BASE: ```c -#define MCU_CONTROL 0x700 -#define MCU_STATUS 0x704 +#define MCU_CONTROL 0x0 +#define MCU_STATUS 0x4 ``` All firmware register accesses switch from `gpu_read(ptdev->iomem, MCU_XXX)` to `gpu_read(fw->iomem, MCU_XXX)`. The arithmetic is correct: `fw->iomem + 0x0` = `ptdev->iomem + 0x700`, matching the original `ptdev->iomem + 0x700`. Clean and straightforward. --- --- Generated by Claude Code Patch Reviewer