public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: Add sysprof accessors
Date: Thu, 23 Apr 2026 09:13:15 +1000	[thread overview]
Message-ID: <review-patch7-20260420222621.417276-8-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20260420222621.417276-8-robin.clark@oss.qualcomm.com>

Patch Review

Good refactor splitting the raw `refcount_read()` checks into two semantically distinct accessors: `msm_gpu_sysprof_no_perfcntr_zap()` and `msm_gpu_sysprof_no_ifpc()`. The comment on `msm_gpu_sysprof_no_ifpc()` clearly explains the planned future divergence.

**Issue**: In `a8xx_gpu.c` `hw_init()`, the change uses `msm_gpu_sysprof_no_perfcntr_zap()`:
```c
if (!ret && msm_gpu_sysprof_no_perfcntr_zap(gpu)) {
    ret = a6xx_gmu_set_oob(gmu, GMU_OOB_PERFCOUNTER_SET);
```
But the `a6xx_gpu.c` `hw_init()` uses `msm_gpu_sysprof_no_ifpc(gpu)` for the same `GMU_OOB_PERFCOUNTER_SET` call. Since this is about disabling IFPC, the a8xx path should also use `msm_gpu_sysprof_no_ifpc()` for consistency, even though the two are currently equivalent. Using the wrong accessor here means when the planned divergence happens, the a8xx path won't be updated correctly.

Also: adding `.sysprof_setup = a6xx_gmu_sysprof_setup` to `a8xx_gpu_funcs` seems like a bug fix that was previously missing -- worth mentioning in the commit message.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-22 23:13 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 22:25 [PATCH 00/13] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-04-20 22:25 ` [PATCH 01/13] drm/msm: Remove obsolete perf infrastructure Rob Clark
2026-04-20 23:49   ` Dmitry Baryshkov
2026-04-21 13:07     ` Rob Clark
2026-04-21 15:39       ` Dmitry Baryshkov
2026-04-21 20:48         ` Rob Clark
2026-04-22  0:41           ` Dmitry Baryshkov
2026-04-22 14:41             ` Rob Clark
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 02/13] drm/msm/adreno: Sync registers from mesa Rob Clark
2026-04-20 23:50   ` Dmitry Baryshkov
2026-04-22 23:13     ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 03/13] drm/msm/registers: Sync gen_header.py " Rob Clark
2026-04-22  3:39   ` Dmitry Baryshkov
2026-04-22 13:36     ` Rob Clark
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 04/13] drm/msm/registers: Add perfcntr json Rob Clark
2026-04-22  3:34   ` Dmitry Baryshkov
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 05/13] drm/msm: Allow CAP_PERFMON for setting SYSPROF Rob Clark
2026-04-21  1:55   ` Dmitry Baryshkov
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 06/13] drm/msm: Add a6xx+ perfcntr tables Rob Clark
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 07/13] drm/msm: Add sysprof accessors Rob Clark
2026-04-22 23:13   ` Claude Code Review Bot [this message]
2026-04-20 22:25 ` [PATCH 08/13] drm/msm/a6xx: Add yield & flush helper Rob Clark
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 09/13] drm/msm: Add per-context perfcntr state Rob Clark
2026-04-22  3:37   ` Dmitry Baryshkov
2026-04-22 14:13     ` Rob Clark
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 10/13] drm/msm: Add basic perfcntr infrastructure Rob Clark
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 11/13] drm/msm/a6xx+: Add support to configure perfcntrs Rob Clark
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 12/13] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 ` [PATCH 13/13] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-04-22  3:41   ` Dmitry Baryshkov
2026-04-22 14:20     ` Rob Clark
2026-04-22 17:48       ` Dmitry Baryshkov
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-22  1:54 ` [PATCH 00/13] " Dmitry Baryshkov
2026-04-22 17:29   ` Rob Clark
2026-04-22 23:13 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-04 19:06 [PATCH v3 00/16] " Rob Clark
2026-05-04 19:06 ` [PATCH v3 07/16] drm/msm: Add sysprof accessors Rob Clark
2026-05-04 22:06   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch7-20260420222621.417276-8-robin.clark@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox