From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: dma: add methods to unsafely create reference from subview
Date: Thu, 23 Apr 2026 08:25:46 +1000
Message-ID: <review-patch7-20260421-io_projection-v2-7-4c251c692ef4@garyguo.net>
In-Reply-To: <20260421-io_projection-v2-7-4c251c692ef4@garyguo.net>
References: <20260421-io_projection-v2-0-4c251c692ef4@garyguo.net> <20260421-io_projection-v2-7-4c251c692ef4@garyguo.net>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Implements `Io` for `Coherent<T>` and adds `as_ref`/`as_mut`/`dma_handle` methods on `View<'_, Coherent<B>, T>`.

The safety contracts on `as_ref`/`as_mut` are appropriate:
```rust
/// * Callers must ensure that the device does not read/write to/from memory
/// * Callers must ensure that this call does not race with a write
```

Minor nit: The safety comment for `as_ref` says "pointer is aligned and valid per type invariant of `View`" which is correct based on the View invariants.

---
Generated by Claude Code Patch Reviewer