From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Use a local iomem base for firmware control registers Date: Tue, 28 Apr 2026 14:28:33 +1000 Message-ID: In-Reply-To: <20260427155934.416502-8-karunika.choo@arm.com> References: <20260427155934.416502-1-karunika.choo@arm.com> <20260427155934.416502-8-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `fw->iomem = ptdev->iomem + MCU_CONTROL_BASE` (0x700). MCU_CONTROL and MCU_STATUS become relative offsets (0x0 and 0x4). Job IRQ accesses go through `fw->irq.iomem`. The old absolute `JOB_INT_RAWSTAT` etc. macros are removed. Doorbell writes continue to use `ptdev->iomem` via `panthor_fw_ring_doorbell()` since doorbells live outside the MCU control window -- this is correctly documented in the commit message. No issues. --- Generated by Claude Code Patch Reviewer