From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Automate CSG IRQ processing at group unbind time Date: Tue, 05 May 2026 11:44:53 +1000 Message-ID: In-Reply-To: <20260429-panthor-signal-from-irq-v1-7-4b92ae4142d2@collabora.com> References: <20260429-panthor-signal-from-irq-v1-0-4b92ae4142d2@collabora.com> <20260429-panthor-signal-from-irq-v1-7-4b92ae4142d2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Looks good.** Moves the `sched_process_csg_irq_locked()` call into `group_unbind_locked()` itself, removing the need for callers to manually call it before unbinding. Also moves `group_bind_locked()` / `group_unbind_locked()` later in the file (after `sched_process_csg_irq_locked`) to avoid forward declarations. This removes the `csg_slot_sync_update_locked()` call in `panthor_sched_suspend()` for the non-flush-failure case, relying on `group_unbind_locked()` to process the pending IRQs instead. This is correct since `group_unbind_locked` now handles it. --- --- Generated by Claude Code Patch Reviewer