From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: document INTR_CTRL interrupt tree Date: Tue, 05 May 2026 09:10:02 +1000 Message-ID: In-Reply-To: <20260501205825.73614-8-joelagnelf@nvidia.com> References: <20260501205825.73614-1-joelagnelf@nvidia.com> <20260501205825.73614-8-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is exceptional documentation. The ASCII diagrams, the explanation of edge-trigger semantics, the REARM vs INTR_RETRIGGER distinction, and the ISR flow are all valuable for anyone working on this code. **Minor typo in cover letter** (not in this patch): "GSP will the host" should be "GSP will notify the host". **Suggestion:** The documentation mentions `INTR_RETRIGGER` as a per-engine register, but this series doesn't implement it. A brief note that this will come in future patches would be helpful for readers. **Overall:** This is a solid, well-tested series. The main actionable items are (1) the selftest returning `Ok(())` on failure and (2) clarifying the IRQ vector lifetime/ownership model in patch 2. --- Generated by Claude Code Patch Reviewer