From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: renesas: vsp1: Use spinlock guards Date: Sat, 16 May 2026 14:29:50 +1000 Message-ID: In-Reply-To: <20260511235637.3468558-8-laurent.pinchart+renesas@ideasonboard.com> References: <20260511235637.3468558-1-laurent.pinchart+renesas@ideasonboard.com> <20260511235637.3468558-8-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Same pattern as patch 5 but for spinlocks. Converts `spin_lock_irqsave()`/`spin_unlock_irqrestore()` and `spin_lock_irq()`/`spin_unlock_irq()` pairs to `guard(spinlock_irqsave)()` and `guard(spinlock_irq)()` respectively. Affected: `vsp1_dl.c`, `vsp1_histo.c`, `vsp1_pipe.c`, `vsp1_video.c`, `vsp1_wpf.c`. Notable: the `vsp1_dlm_irq_frame_end()` conversion replaces `goto done` at the end-of-function unlock with direct `return flags`, since `guard(spinlock)` handles the unlock. Clean refactoring. The `vsp1_pipeline_stopped()` conversion is particularly nice, reducing 5 lines to 2: ```c guard(spinlock_irqsave)(&pipe->irqlock); return pipe->state == VSP1_PIPELINE_STOPPED; ``` **All correct.** --- Generated by Claude Code Patch Reviewer