From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/colorop: Create drm_atomic_helper_colorop_create_state() Date: Sat, 16 May 2026 13:22:53 +1000 Message-ID: In-Reply-To: <20260512-drm-mode-config-init-v4-7-591dfdcc1bf9@kernel.org> References: <20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org> <20260512-drm-mode-config-init-v4-7-591dfdcc1bf9@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Creates the new create_state helper for colorop. Uses `kzalloc_obj(*state)` + `__drm_colorop_state_init()`. Returns `ERR_PTR(-ENOMEM)` on failure. Note: this function is **not exported** (no `EXPORT_SYMBOL`), which is correct since it's only called from within `drm_colorop.c` and `drm_mode_config.c` (both in the same module). The declaration in `drm_colorop.h` does make it visible to other in-tree code though. Fine as-is. No issues. --- Generated by Claude Code Patch Reviewer