From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: driver core: platform: tests: add test cases for correct swnode removal Date: Sat, 16 May 2026 13:28:31 +1000 Message-ID: In-Reply-To: <20260512-swnode-remove-on-dev-unreg-v5-7-0035eff63812@oss.qualcomm.com> References: <20260512-swnode-remove-on-dev-unreg-v5-0-0035eff63812@oss.qualcomm.com> <20260512-swnode-remove-on-dev-unreg-v5-7-0035eff63812@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Three well-structured test cases: 1. **`platform_device_swnode_add_twice`**: Verifies that a swnode can be re= used after device unregister =E2=80=94 directly tests the bug this series f= ixes. 2. **`platform_device_swnode_as_primary`**: Verifies that passing a registe= red software node as the primary fwnode doesn't cause it to be unregistered= by the release path. The `fwnode_handle_get()` from patch 5 is what makes = this work. 3. **`platform_device_two_swnodes`**: Validates all three double-swnode rej= ection cases from patch 2. Minor nit: `platform_device_swnode_add_twice` uses a raw `fwnode_init(&fwno= de, NULL)` to create a non-software-node primary fwnode. This is a bit unus= ual but serves the test's purpose. No functional issues. --- Generated by Claude Code Patch Reviewer