From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: rockchip: Add eDP node for RK3576 Date: Sat, 16 May 2026 12:26:18 +1000 Message-ID: In-Reply-To: <20260513074414.2053435-8-damon.ding@rock-chips.com> References: <20260513074414.2053435-1-damon.ding@rock-chips.com> <20260513074414.2053435-8-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good** Adds a complete eDP node at `0x27dc0000` for RK3576, correctly placed before the existing DP node at `0x27e40000`. The node correctly uses: - `HCLK_VO0_ROOT` (not `HCLK_VO1` like RK3588 -- appropriate for RK3576's VO0 domain) - `power-domains = <&power RK3576_PD_VO0>` (correct power domain) - `rockchip,grf = <&vo0_grf>` (required by binding) - Two resets matching the binding requirement for RK3576/RK3588 compatibles - Standard port structure with `port@0` (input) and `port@1` (output) Already has Reviewed-by from Nicolas Frattaroli. --- Generated by Claude Code Patch Reviewer