From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: dw_hdmi: Hold bridge ref until connector cleanup
Date: Mon, 18 May 2026 16:41:46 +1000
Message-ID: <review-patch7-20260516183838.2024991-8-jonas@kwiboo.se>
In-Reply-To: <20260516183838.2024991-8-jonas@kwiboo.se>
References: <20260516183838.2024991-1-jonas@kwiboo.se> <20260516183838.2024991-8-jonas@kwiboo.se>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status:** Important fix.

Addresses a use-after-free where `dw_hdmi_bridge_destroy()` freed `struct dw_hdmi` before `drm_connector_cleanup()` ran. The fix:
```c
+	drm_bridge_get(&hdmi->bridge);
```
at connector init, and:
```c
+	drm_connector_cleanup(connector);
+	drm_bridge_put(&hdmi->bridge);
```
at connector destroy. Also properly checks the return of `drm_connector_init_with_ddc()` which was previously ignored. Good fix.

---
Generated by Claude Code Patch Reviewer