From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/hdmi: Use the common TMDS char rate constants in 8996 PHY
Date: Mon, 25 May 2026 22:44:50 +1000
Message-ID: <review-patch7-20260519144712.1418302-8-javierm@redhat.com>
In-Reply-To: <20260519144712.1418302-8-javierm@redhat.com>
References: <20260519144712.1418302-1-javierm@redhat.com> <20260519144712.1418302-8-javierm@redhat.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Removes `#define HDMI_PCLK_MAX_FREQ 600000000` and `#define HDMI_PCLK_MIN_FREQ 25000000` from `hdmi_phy_8996.c`, replacing them with `DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0` and `DRM_HDMI_TMDS_CHAR_RATE_MIN` respectively. The values are exact matches. Adds the required `#include <drm/display/drm_hdmi_helper.h>`.

The `clamp_t` line is reformatted to wrap at 80 columns, which is a sensible style improvement.

**No issues.**

---

---
Generated by Claude Code Patch Reviewer