From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: sc8280xp-arcata: Add volume up/down GPIO keys Date: Mon, 25 May 2026 21:20:09 +1000 Message-ID: In-Reply-To: <20260520-surface-sp9-5g-for-next-v1-7-9df52552bf87@gmail.com> References: <20260520-surface-sp9-5g-for-next-v1-0-9df52552bf87@gmail.com> <20260520-surface-sp9-5g-for-next-v1-7-9df52552bf87@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **No issues.** Adds volume up (gpio9) and down (gpio6) as GPIO keys on `pmc8280_1_gpios` with proper pinctrl (input-enable, bias-pull-up, power-source = <1>). The debounce of 15ms, `linux,can-disable`, and `wakeup-source` are standard for this type of key. The `gpio-keys.h` include is correctly added. --- Generated by Claude Code Patch Reviewer