From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/hdmi: Use the common TMDS char rate constants in 8996 PHY Date: Mon, 25 May 2026 21:45:02 +1000 Message-ID: In-Reply-To: <20260520144424.1633354-8-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> <20260520144424.1633354-8-javierm@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces `HDMI_PCLK_MAX_FREQ` (600000000) and `HDMI_PCLK_MIN_FREQ` (25000000) with `HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ` and `HDMI_TMDS_CHAR_RATE_MIN_HZ`: ```c - req->rate = clamp_t(unsigned long, req->rate, HDMI_PCLK_MIN_FREQ, HDMI_PCLK_MAX_FREQ); + req->rate = clamp_t(unsigned long, req->rate, HDMI_TMDS_CHAR_RATE_MIN_HZ, + HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ); ``` **Minor semantic note:** The old defines used "PCLK" (pixel clock) terminology, and the new ones use "TMDS character rate". These are equivalent at 8bpc without pixel repetition, and since this is a PLL providing the TMDS clock the new naming is arguably more precise. The values are identical either way. No issues. **Reviewed-by tag:** Dmitry Baryshkov. --- Generated by Claude Code Patch Reviewer