From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: driver core: platform: provide platform_device_set_fwnode()
Date: Mon, 25 May 2026 20:33:08 +1000
Message-ID: <review-patch7-20260521-pdev-fwnode-ref-v1-7-88c324a1b8d2@oss.qualcomm.com>
In-Reply-To: <20260521-pdev-fwnode-ref-v1-7-88c324a1b8d2@oss.qualcomm.com>
References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> <20260521-pdev-fwnode-ref-v1-7-88c324a1b8d2@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

```c
void platform_device_set_fwnode(struct platform_device *pdev,
				struct fwnode_handle *fwnode)
{
	if (is_of_node(fwnode))
		platform_device_set_of_node(pdev, to_of_node(fwnode));
	else
		pdev->dev.fwnode =3D fwnode;
}
```

This is intentionally asymmetric at this stage =E2=80=94 non-OF fwnodes are=
 NOT refcounted yet, matching the current behavior of `platform_device_rele=
ase()` which only does `of_node_put()`. Patch 23 will unify this. The desig=
n is correct as a transitional step.

---
Generated by Claude Code Patch Reviewer