From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: writeback: Modify cleanup_writeback_job helper Date: Mon, 25 May 2026 20:57:37 +1000 Message-ID: In-Reply-To: <20260521053708.1475129-8-suraj.kandpal@intel.com> References: <20260521053708.1475129-1-suraj.kandpal@intel.com> <20260521053708.1475129-8-suraj.kandpal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Changes the `cleanup_writeback_job` vtable hook from taking `drm_writeback_= connector *` to `drm_connector *`. Correct and clean. The vkms cleanup nice= ly removes the manual `container_of` that was added in patch 1. No issues. --- **Summary:** The series direction is correct and the overall design is soun= d. The **critical issue** is the bug in patch 4 where `acrtc->connector` is= used instead of `drm_writeback_to_connector(acrtc->wb_conn)` in `dm_crtc_h= igh_irq` =E2=80=94 this would pass the wrong connector entirely. There are = also a handful of typos in doc comments ("valriables", "whicha", "consitenc= y" in changelogs, double-space) and one parameter naming inconsistency in t= he header for `drm_writeback_queue_job`. --- Generated by Claude Code Patch Reviewer