From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: rockchip: Add eDP node for RK3576 Date: Mon, 25 May 2026 20:40:13 +1000 Message-ID: In-Reply-To: <20260521080835.1362416-8-damon.ding@rock-chips.com> References: <20260521080835.1362416-1-damon.ding@rock-chips.com> <20260521080835.1362416-8-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Full DTS node for RK3576 eDP controller: ```dts + edp: edp@27dc0000 { + compatible =3D "rockchip,rk3576-edp"; + reg =3D <0x0 0x27dc0000 0x0 0x1000>; + clocks =3D <&cru CLK_EDP0_24M>, <&cru PCLK_EDP0>, <&cru HCLK_VO0_ROOT>; + clock-names =3D "dp", "pclk", "hclk"; ``` The node looks complete with clocks, interrupt, phy, power-domain, resets, = and GRF reference. Note that RK3576 uses `HCLK_VO0_ROOT` (VO**0**) while RK= 3588 uses `HCLK_VO1` =E2=80=94 this makes sense as RK3576's eDP is in the V= O0 domain. The register address `0x27dc0000` matches the `reg` field in the chip data = added in patch 10. Port nodes are correctly defined. No issues. --- Generated by Claude Code Patch Reviewer