From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic-helper: Add HDMI bridge output bus formats helper Date: Mon, 25 May 2026 18:48:54 +1000 Message-ID: In-Reply-To: <20260522-color-format-v15-7-21fb136c9df2@collabora.com> References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> <20260522-color-format-v15-7-21fb136c9df2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The `BUILD_BUG_ON(const_true(DRM_OUTPUT_COLOR_FORMAT_COUNT > 8))` guard for= the `hweight8` call is a pragmatic approach. The commit message's lengthy = justification for not using `hweight32` is perhaps overthinking it =E2=80= =94 the compiler would likely optimize this regardless on modern architectu= res =E2=80=94 but it's harmless. Minor doc typo: "bits per compoennt" should be "bits per component". ```c * representing all the MEDIA_BUS_FMTS\_ for the current connector state's * chosen HDMI output bits per compoennt, or %NULL if it fails to allocate = one. ``` --- Generated by Claude Code Patch Reviewer