From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: writeback: Modify cleanup_writeback_job helper Date: Mon, 25 May 2026 19:19:16 +1000 Message-ID: In-Reply-To: <20260522050313.1800378-8-suraj.kandpal@intel.com> References: <20260522050313.1800378-1-suraj.kandpal@intel.com> <20260522050313.1800378-8-suraj.kandpal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes the `cleanup_writeback_job` callback in `struct drm_connector_helper_funcs` from taking `struct drm_writeback_connector *` to `struct drm_connector *`. **Analysis:** Correct. The vkms driver cleanup is the biggest win here, removing the manual `container_of` that was added in patch 1: ```c -static void vkms_wb_cleanup_job(struct drm_writeback_connector *wb_conn, +static void vkms_wb_cleanup_job(struct drm_connector *connector, struct drm_writeback_job *job) { struct vkms_writeback_job *vkmsjob = job->priv; - struct drm_connector *connector = container_of(wb_conn, - struct drm_connector, - writeback); ``` No issues. --- **Summary:** The series design is sound and well-structured. The blocking issue is the **build-breaking bug in patch 4** where `acrtc->connector` is used but doesn't exist (should be `drm_writeback_to_connector(acrtc->wb_conn)`). There's also a minor typo ("valriables") in patch 1's kerneldoc. The `encoder` field removal from `drm_writeback_connector` should be explicitly documented. Once the amdgpu bug is fixed, the series should be in good shape. --- Generated by Claude Code Patch Reviewer