From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic-helper: Add HDMI bridge output bus formats helper Date: Mon, 25 May 2026 17:26:09 +1000 Message-ID: In-Reply-To: <20260523-color-format-v16-7-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> <20260523-color-format-v16-7-24340c5e4732@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Well-structured helper. The `BUILD_BUG_ON(const_true(DRM_OUTPUT_COLOR_FORMA= T_COUNT > 8))` guard for `hweight8` is a nice touch. The format ordering (R= GB first, then YCbCr444, YCbCr422, YCbCr420) within each BPC level is consi= stent. **Missing format:** The 10-bit case handles `MEDIA_BUS_FMT_UYVY10_1X20` for= YCbCr422, but the `bus_format_is_color_fmt()` function in patch 6 also kno= ws about `MEDIA_BUS_FMT_YUYV10_1X20`, `MEDIA_BUS_FMT_VYUY10_1X20`, `MEDIA_B= US_FMT_YVYU10_1X20`. This is fine =E2=80=94 the helper only needs to produc= e *one* representative format per color format per BPC =E2=80=94 but it mea= ns bridges downstream must handle the specific variant chosen here (`UYVY10= _1X20`). --- Generated by Claude Code Patch Reviewer