From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: rockchip: Add eDP node for RK3576 Date: Tue, 26 May 2026 07:34:42 +1000 Message-ID: In-Reply-To: <20260525082033.117569-8-damon.ding@rock-chips.com> References: <20260525082033.117569-1-damon.ding@rock-chips.com> <20260525082033.117569-8-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds the full eDP node to `rk3576.dtsi`: ```dts + edp: edp@27dc0000 { + compatible = "rockchip,rk3576-edp"; + reg = <0x0 0x27dc0000 0x0 0x1000>; + clocks = <&cru CLK_EDP0_24M>, <&cru PCLK_EDP0>, <&cru HCLK_VO0_ROOT>; + clock-names = "dp", "pclk", "hclk"; ``` The node is well-formed with all required properties (clocks, interrupts, phys, power-domains, resets, rockchip,grf). Note that RK3576 uses `HCLK_VO0_ROOT` (VO0) vs RK3588's `HCLK_VO1` -- this is expected since RK3576 has eDP on VO0. Status is "disabled" which is correct for SoC dtsi. The node placement is at `0x27dc0000` which matches the `reg` in the chip data in patch 10. --- Generated by Claude Code Patch Reviewer