From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/colorop: Create drm_atomic_helper_colorop_create_state() Date: Wed, 27 May 2026 14:30:50 +1000 Message-ID: In-Reply-To: <20260526-drm-mode-config-init-v6-7-852346394200@kernel.org> References: <20260526-drm-mode-config-init-v6-0-852346394200@kernel.org> <20260526-drm-mode-config-init-v6-7-852346394200@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces `drm_atomic_helper_colorop_create_state()` for colorops. The function allocates with `kzalloc_obj(*state)`, initializes via `__drm_colorop_state_init()`, and returns `ERR_PTR(-ENOMEM)` on failure. Pattern is correct. Note: This function is not `EXPORT_SYMBOL`'d despite the declaration being added to the header. Since it's only called from within the DRM core (`drm_mode_config_create_initial_state()` in patch 16), this works but is inconsistent with the plane/crtc/connector helpers which are all exported. Not a bug, but worth noting if out-of-tree users need it. --- Generated by Claude Code Patch Reviewer