From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: rockchip: Add eDP node for RK3576 Date: Wed, 27 May 2026 13:55:46 +1000 Message-ID: In-Reply-To: <20260527024336.191433-8-damon.ding@rock-chips.com> References: <20260527024336.191433-1-damon.ding@rock-chips.com> <20260527024336.191433-8-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The DTS node looks complete and follows the RK3588 pattern: ```dts + edp: edp@27dc0000 { + compatible =3D "rockchip,rk3576-edp"; + reg =3D <0x0 0x27dc0000 0x0 0x1000>; + clocks =3D <&cru CLK_EDP0_24M>, <&cru PCLK_EDP0>, <&cru HCLK_VO0_ROOT>; + clock-names =3D "dp", "pclk", "hclk"; ``` Note: RK3576 uses `HCLK_VO0_ROOT` (VO0 domain) while RK3588 uses `HCLK_VO1`= (VO1 domain) =E2=80=94 this is correct as RK3576 has the eDP on VO0. The n= ode placement between HDMI and DP nodes respects address ordering. The two-= port structure with `edp_in` and `edp_out` follows the expected pattern. No issues. --- Generated by Claude Code Patch Reviewer